Clamp records to time range when filtering by time#119
Open
preethamrn wants to merge 3 commits intoRazeeman:devfrom
Open
Clamp records to time range when filtering by time#119preethamrn wants to merge 3 commits intoRazeeman:devfrom
preethamrn wants to merge 3 commits intoRazeeman:devfrom
Conversation
Contributor
Author
|
I'm planning on fixing the failing tests but would like to hear opinions on how to best implement and integrate this feature before making too many more changes. |
Owner
|
Hello! This would be a useful feature indeed. Clamping probably shouldn't be implemented in RecordFilterInteractor because it's purpose is to filter records and not change them. For example this interactor is used to get records that are going to be changed in Data Edit screen, and it would break the logic if the records are not original. I think it would make more sense to create another interactor what would perform clamping and use it on filtered records there it is necessary. |
Razeeman
force-pushed
the
dev
branch
5 times, most recently
from
3df8549 to
aaed392
Compare
Razeeman
force-pushed
the
dev
branch
5 times, most recently
from
0e93029 to
9308b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there should be a feature to clamp time records to the filtered time range instead of including the full record length. This way, it's possible to get statistics for that specific time range (eg. Activity Durations) instead of displaying the full activity.
Scenarios in which this is useful:
Let's say I have a Work record that typically goes from 900-1700. On one day, the record goes from 900-1900.
If I filter the time range from 1700-2200 then I will see this 10 hour Work record even though I'm more interested in the time range after work and would expect to only see 2 hours of Work.
There are a handful of changes in this pull request: